8352567: [s390x] disable JFR tests requiring JFR stubs #28444
Conversation
|
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@offamitkumar Hi, would it be possible to take a look? =) |
offamitkumar
left a comment
offamitkumar
left a comment
There was a problem hiding this comment.
I would've suggested to use @requires vm.continuations that way test will be disabled if continuations support is not there. Or probably we can do simple problem listing, that way it will be little easy to enable the test case again.
Reason:
#if INCLUDE_JFR
RuntimeStub* SharedRuntime::generate_jfr_write_checkpoint() {
if (!Continuations::enabled()) return nullptr;
Unimplemented();
return nullptr;
}
RuntimeStub* SharedRuntime::generate_jfr_return_lease() {
if (!Continuations::enabled()) return nullptr;
Unimplemented();
return nullptr;
}
#endif // INCLUDE_JFRwe can see that we are going to return nullptr even if the stub is implemented in case continuations is disabled.
But it seems once these stubs were implemented for other architectures the requirement for continuations support vanished.
See aarch64 for example:
@theRealAph could you suggest if this solution looks correct ?
|
I see this testcase failing in tier1 tests on headstream: |
2 participants
JFR stubs are not implemented.
Add platform requirement to JFR tests that require JFR stubs to skip them on S390x.
Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28444/head:pull/28444$ git checkout pull/28444Update a local copy of the PR:
$ git checkout pull/28444$ git pull https://git.openjdk.org/jdk.git pull/28444/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28444View PR using the GUI difftool:
$ git pr show -t 28444Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28444.diff
Using Webrev
Link to Webrev Comment